Skip to content

Conversation

@leolost2605
Copy link
Member

Towards #2556

@leolost2605
Copy link
Member Author

leolost2605 commented Dec 27, 2025

@tintou any tips for updating the vapi? Completely manually or using vapigen and taking the diff? Or do you have a script somewhere? I tried to do a vapigen for Mutter clutter but I got stuck at it thinking Atk.Implementor is a class and saying can't derive from two classes :/

@leolost2605 leolost2605 changed the title Continue 49 support Finish 49 support Dec 27, 2025
@leolost2605 leolost2605 marked this pull request as draft December 27, 2025 15:25
@garaevdi
Copy link
Contributor

garaevdi commented Jan 7, 2026

I've been testing some additional changes on top of this branch and gala seems working fine with them. I'd like to contribute them back and I was wondering what would be the preferred approach: opening a PR against this branch, or against main with this branch as a base?

@amz-x
Copy link

amz-x commented Jan 7, 2026

@garaevdi not sure what the rule of thumb here is, but personally would go with the latter option. Using this PR as base against the main branch.

@leolost2605
Copy link
Member Author

@garaevdi a PR against main would be great, thanks!

@garaevdi garaevdi mentioned this pull request Jan 7, 2026
@tintou
Copy link
Member

tintou commented Jan 8, 2026

@tintou any tips for updating the vapi? Completely manually or using vapigen and taking the diff? Or do you have a script somewhere? I tried to do a vapigen for Mutter clutter but I got stuck at it thinking Atk.Implementor is a class and saying can't derive from two classes :/

Sorry, I somehow missed your message, what I'm usually doing is adding vapi generation support first in the vapi/meson.build and using the .vapi generated from there and manually changing the files, it takes usually a few hours to do 😅

@danirabbit
Copy link
Member

Closing since this was incorporated into a merged branch :)

@danirabbit danirabbit closed this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants