-
-
Notifications
You must be signed in to change notification settings - Fork 78
Finish 49 support #2702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish 49 support #2702
Conversation
|
@tintou any tips for updating the vapi? Completely manually or using vapigen and taking the diff? Or do you have a script somewhere? I tried to do a vapigen for Mutter clutter but I got stuck at it thinking Atk.Implementor is a class and saying can't derive from two classes :/ |
|
I've been testing some additional changes on top of this branch and gala seems working fine with them. I'd like to contribute them back and I was wondering what would be the preferred approach: opening a PR against this branch, or against main with this branch as a base? |
|
@garaevdi not sure what the rule of thumb here is, but personally would go with the latter option. Using this PR as base against the main branch. |
|
@garaevdi a PR against main would be great, thanks! |
Sorry, I somehow missed your message, what I'm usually doing is adding vapi generation support first in the vapi/meson.build and using the .vapi generated from there and manually changing the files, it takes usually a few hours to do 😅 |
|
Closing since this was incorporated into a merged branch :) |
Towards #2556