Skip to content

Conversation

@danirabbit
Copy link
Member

Use Gtk.ColorDialog, add provider for display

@danirabbit danirabbit requested a review from a team March 20, 2025 20:12
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The color dialog appears at (0, 0) of the screen rather then centered. Other than that looks good.

@danirabbit
Copy link
Member Author

Screenshot from 2025-03-27 10 45 17

@jeremypw can't confirm that. It appears centered on the window here. Are you still running OS 7? Maybe an OS 7 bug?

@jeremypw
Copy link
Contributor

@danirabbit It happens in Classic session but not in Secure session for me. However, I am running OS8 in a VM on OS7.1

@danirabbit
Copy link
Member Author

@jeremypw I can confirm the window is spawning at 0,0 in X11, but we're dimming the correct window so the parent is being set correctly here. There's nothing I can do to set the window position other than setting the parent. So this must be a bug somewhere else

Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to have neglected this. I agree this is an upstream bug in the way the Gtk4 ColorDialog (hopefully not child windows more generally) are positioned under X11. Hopefully we can make the Wayland session default soon and then it will be less of an issue. I'll approve and then you can decide whether to merge now or later.

@danirabbit danirabbit enabled auto-merge (squash) July 4, 2025 22:36
@danirabbit danirabbit merged commit fe40454 into main Jul 4, 2025
5 checks passed
@danirabbit danirabbit deleted the danirabbit/demo-utilsview-deprecations branch July 4, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants