-
-
Notifications
You must be signed in to change notification settings - Fork 61
Demo/UtilsView: fix deprecation warnings #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jeremypw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The color dialog appears at (0, 0) of the screen rather then centered. Other than that looks good.
|
@jeremypw can't confirm that. It appears centered on the window here. Are you still running OS 7? Maybe an OS 7 bug? |
|
@danirabbit It happens in Classic session but not in Secure session for me. However, I am running OS8 in a VM on OS7.1 |
|
@jeremypw I can confirm the window is spawning at 0,0 in X11, but we're dimming the correct window so the parent is being set correctly here. There's nothing I can do to set the window position other than setting the parent. So this must be a bug somewhere else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to have neglected this. I agree this is an upstream bug in the way the Gtk4 ColorDialog (hopefully not child windows more generally) are positioned under X11. Hopefully we can make the Wayland session default soon and then it will be less of an issue. I'll approve and then you can decide whether to merge now or later.

Use Gtk.ColorDialog, add provider for display