Styles/Controls: prototype focus styles #787
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
commented
Mar 28, 2025
lib/Styles/Common/_controls.scss
Outdated
| outline-color: #{'alpha(@BLUEBERRY_300, 0.3)'}; | ||
| } | ||
|
|
||
| outline-width: rem(2px); |
Member
Author
There was a problem hiding this comment.
Unfortunately we still have elementary/stylesheet#904 with linked buttons. I wonder if maybe we should forget the outline property and use box-shadow?
Member
There was a problem hiding this comment.
I think it's worth exploring. Using box-shadow might also remove some of the funky effects of the shadow and the focus indicator overlapping.
Member
Author
|
It looks like Adw has some more complicated focus ring handling that it's probably worth looking at. They also do the thing of dismissing the focus ring after some time: https://gitlab.gnome.org/GNOME/libadwaita/-/blob/main/src/stylesheet/_drawing.scss#L12 https://gitlab.gnome.org/GNOME/libadwaita/-/blob/main/src/stylesheet/_common.scss#L3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.