-
-
Notifications
You must be signed in to change notification settings - Fork 61
Widgets: Add TerminalView #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wpkelso
wants to merge
21
commits into
main
Choose a base branch
from
wpkelso/widgets/TerminalView
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
9e3e8d6
add terminal cssclass
wpkelso 764640e
add widget shell
wpkelso 1306caa
add autoscroll from installer
wpkelso 7102eef
clean up display
wpkelso 1a92a46
add autoscroll enable/disable
wpkelso 727cb15
remove erroneous whitespace
wpkelso 2c27d3e
Merge branch 'main' into wpkelso/widgets/TerminalView
wpkelso 1f93fde
Move terminal output view to separate page, clean up api a litte
wpkelso 9e24e49
clean up whitespace, add comments
wpkelso 37602bf
Move terminal view class to it's own file
wpkelso 2af81a7
change CssClass to internal
wpkelso 35626e7
add enable/disable autoscroll?
wpkelso 5650bb3
Better show autoscroll
wpkelso 2828f71
fix lint error?
wpkelso 63a10f5
Merge branch 'main' into wpkelso/widgets/TerminalView
wpkelso 54f57e8
Merge branch 'main' into wpkelso/widgets/TerminalView
wpkelso 2e04a2d
Apply suggestions from code review
wpkelso 04bcee4
remove commented code, use bound properties
wpkelso 70f7af5
Merge branch 'main' into wpkelso/widgets/TerminalView
wpkelso 899fdc2
Deduplicate text properties, fix errors in dmeo
wpkelso a4609c0
Merge branch 'main' into wpkelso/widgets/TerminalView
wpkelso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| * Copyright 2025 elementary, Inc. (https://elementary.io) | ||
| * SPDX-License-Identifier: GPL-2.0-or-later | ||
| */ | ||
|
|
||
| [Version (since = "7.7.0")] | ||
| public class Granite.TerminalView : Gtk.ScrolledWindow { | ||
|
|
||
| public TerminalView () { | ||
wpkelso marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| this.add_css_class (Granite.CssClass.TERMINAL); | ||
| } | ||
wpkelso marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| public TerminalView.with_textview ( | ||
| Gtk.TextView view = new Gtk.TextView () { | ||
wpkelso marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| cursor_visible = true, | ||
| margin_end = 6, | ||
| editable = false, | ||
| margin_start = 6, | ||
| monospace = true, | ||
| pixels_below_lines = 3, | ||
| wrap_mode = Gtk.WrapMode.WORD | ||
| } | ||
| ) { | ||
| this.child = view; | ||
| } | ||
|
|
||
| // We may not need this, as we could use an un-editable TextView and | ||
| // simplify the API | ||
| public TerminalView.with_label (Gtk.Label label) { | ||
| this.child = label; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.