Move Granite specific button styles to Granite Dir #872
Conversation
lib/Styles/Granite/Button.scss
Outdated
|
|
||
| // Overwrite changes made further down the cascade due to the way | ||
| // @extend works | ||
| padding: 0; |
There was a problem hiding this comment.
This padding removal seems like an error?
Main:
This branch:
There was a problem hiding this comment.
button.text-button sets a padding of rem(2px) rem(4px), which then gets inherited when we extend it. This is supposed to override that and reset the padding. Before, we got around this by setting the padding for .text-button in a block specific to .text-button, and setting everything else in a shared block.
Compiled as it currently is, the padding is not being overridden. I'm not really sure why, though. Sheets might be cascading in a way I'm not expecting?
There was a problem hiding this comment.
I see what you're saying. Because we want text buttons to have more horizontal padding and image buttons to have even padding all the way around.
Maybe what we need to do instead then is have a .raised style that just handles the borders and have .linked and .text-button extend that, separately
There was a problem hiding this comment.
I've split it out using a placeholder class. For some reason the checked and active selectors still had to be overriden
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
This looks good to me and I think it makes sense as far as organization goes. Nice job!
Rel: feedback on #870