-
-
Notifications
You must be signed in to change notification settings - Fork 60
Flatpak: Add manifest #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I will admit, I'm not familiar with Granite. I'm getting these errors: Click to expand
I presume this is being caused by the Flatpak using the runtime's version...? |
|
Could you tell us the reason why you need this? 🤔 |
|
I discussed it with @danirabbit in private, and she let me know that she's been thinking of doing it, so it's nothing that benefits me really :) |
|
@TheEvilSkeleton yeah this is because those widgets, classes, etc are not released yet in stable Granite. Only in main. So the manifest needs to use Granite from main I suppose @ryonakano it's something I talked about previously with William. It would be nice to be able to test against newer GTK features for the new stylesheet etc as we're developing |
hmm, it's weird that the Demo app seems to fail to build despite using |
This comment was marked as outdated.
This comment was marked as outdated.
| { | ||
| "name" : "libsass", | ||
| "buildsystem" : "meson", | ||
| "sources" : [ | ||
| { | ||
| "type" : "git", | ||
| "url" : "https://github.com/lazka/libsass.git", | ||
| "branch" : "meson" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "name" : "sassc", | ||
| "buildsystem" : "meson", | ||
| "sources" : [ | ||
| { | ||
| "type" : "git", | ||
| "url" : "https://github.com/lazka/sassc.git", | ||
| "branch" : "meson" | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danirabbit I guess we don't need to install sassc again here if we quit cleaning them up in the SDK manifest. What do you think?
|
@ryonakano could you mark this pull request as draft? I don't remember how we do that on GitHub... It currently doesn't even build due to meson limitations. Someone offered to add some functionality into meson but we'll have to wait for the next version to be released. |
@leonardo-lemos did that. FYI you can do that under the Reviewers section in the right side of PRs:
@TheEvilSkeleton Could you elaborate on this? What do you mean with "the meson limitations"? And which PR did add the "some functionality" in https://github.com/mesonbuild/meson? |
Thanks!
mesonbuild/meson#14782 - I accidentally mentioned PR rather than "an unpushed commit from someone else's system" 😅 |
This is needed to use the repo's generated library, rather than the system's.
|
Just to reiterate: at the time of writing this, this PR won't work on the latest stable version of meson; only on mesonbuild/meson#14782. You can install and run that version with: $ pip install git+https://github.com/dcbaker/meson@submit/vala-header-method
$ meson setup --reconfigure _build
$ meson compile -C _build/
$ ./_build/demo/granite-7-demo |

No description provided.