Add dark style support #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardo-lemos
approved these changes
May 9, 2025
Collaborator
leonardo-lemos
left a comment
leonardo-lemos
left a comment
There was a problem hiding this comment.
Works as expected, nice job!
Member
Author
|
It should respect dark style schedule now. It would be awesome if more people tested whether this approach works on their machine :) |
danirabbit
approved these changes
May 12, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
This is a very interesting approach! Works perfectly for me
Member
|
Doesn't seem like anyone has objected to this so let's merge it for testing in Daily |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #688
Closes #563
Closes #499
This branch implements mini settings portal inside of the greeter itself and exposes it via dbus which allows granite to correctly get dark style preference