ShellClientsManager: centered windows are not always shell windows#851
Merged
Conversation
leolost2605
requested changes
Jan 6, 2026
Member
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
Since we can't make modal without the protocol and everything I think it would be better to leave that out for now and just remove the (window in positioned_windows) ||
Member
Author
|
No problem! I was trying to think about what would be easier to not mess up later to add modal support but I can absolutely do that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #elementary/installer#917
Based on changes from elementary/gala#2709
It looks like Greeter Compositor isn't currently using
ExtendedBehaviorWindow. It would create a pretty large diff to add that here, so workaround that for now by just adding modal/dim function/property to ShellWindow