Skip to content

Conversation

@wpkelso
Copy link
Member

@wpkelso wpkelso commented Jan 25, 2025

Fixes #1274

Compositing is done through a python script located in the new scripts folder in the repo root, called by the meson build file in the mimes directory.

Currently, the script takes a naive approach and makes a couple of key assumptions:

  • Both SVGs have the same dimensions
  • Both SVGs are aligned correctly already, and there is no intended interleaving of elements between files
  • All shapes, paths, defs, etc. do not have id collisions

"generic", "executable", and "package" base shapes are covered. "books" are not. "template" decorations are also added in a second pass.

* The majority of line changes in this PR are artifacts from removing base shapes *

Extras

  • Rim light stops have been adjusted to be consistent for the "executable" base

Potential Future Extensions:

  • create template files during build process, so everything about them except the decoration is kept consistent with their base file
  • target "book" bases as well. This requires manipulating the fill colors of specific elements

@wpkelso wpkelso marked this pull request as ready for review January 26, 2025 04:13
@wpkelso wpkelso requested a review from a team January 26, 2025 04:14
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job! This all looks good and makes sense to me. Thank you! 🎉

@danirabbit danirabbit merged commit 13dbb8a into elementary:main Feb 6, 2025
3 checks passed
@wpkelso wpkelso deleted the compose-mime branch February 6, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Composite file type icons

2 participants