Use system-help as central "question mark" icon
#1351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where question mark symlinks sometimes linked to `/actions/*/help-contents.svg` and sometimes linked to `/status/*/dialog-question.svg`. Now `categories/*/system-help.svg` is the question mark icon from which all other question mark icons symlink.
danirabbit
approved these changes
Jul 1, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
This makes sense to me! Good cleanup 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a very trivial change but it centralizes the source of the "real" (non-symlink) question mark icon to
system-help.Fixes issue where question mark symlinks sometimes linked to
/actions/*/help-contents.svgand sometimes linked to/status/*/dialog-question.svg.Now
categories/*/system-help.svgis the question mark icon from which all other question mark icons symlink.A little more explanation and possible background...
The question mark icon at one time was located at
action/help-contents.svg, and all other questionmark icons were symlinked from there. At one point
the action icons above 48px were removed, and the
symlinks became fragmented.
The
statusfolderdialog-questionhad symlinks toactionsup to 48px, then had real icons for 64px and 128px.Then
/categories/*/system-help.svglinked sometimes toactionsand sometimes tostatus.I figured since
system-helpexisted in all sizes, andcategoriesis sort of a system-wide concept, it would make sense to use
that one to be the source from which the others linked to.