Skip to content

Conversation

@daudix
Copy link
Contributor

@daudix daudix commented Aug 11, 2025

Currently, if no fitting icon is found in elementary icon theme, gtk falls back to hicolor, as per the fd.o spec. With this PR, it will first try to find missing icon in Adwaita (which is present in elementary OS) before resorting to displaying a missing icon image. This issue mainly affects GNOME Circle apps that heavily rely on Adwaita, and while it is recommended to bundle all non-fd.o icons, not all apps do so (unfortunately).

Before/after examples (Apostrophe and Ptyxis):

Screenshot from 2025-08-11 22 07 16 Screenshot from 2025-08-11 22 06 50 Screenshot from 2025-08-11 22 27 56 Screenshot from 2025-08-11 22 28 12

@danirabbit
Copy link
Member

I don't have any objections to this. Just need to double check what the behavior is here with gresourced icons from Granite and make sure GNOME icons don't override that

@daudix
Copy link
Contributor Author

daudix commented Aug 11, 2025

Went through all core and some AppCenter apps, as well as granite-demo, and elementary icons seem to always take priority over Adwaita.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell this works as expected and doesn't override icons gresourced in granite

@danirabbit danirabbit enabled auto-merge (squash) August 12, 2025 18:41
@danirabbit danirabbit merged commit 3aceb24 into elementary:main Aug 12, 2025
3 checks passed
@daudix daudix deleted the inherits-adwaita branch August 12, 2025 22:23
@tintou
Copy link
Member

tintou commented Aug 13, 2025

It doesn't seem to be a good thing to me, if the icons are missing, it means that the app has to gressource the fallback icon

@danirabbit
Copy link
Member

@tintou I agree they definitely should, but OP is right that a lot of apps don't do it :/ So it helps to be a little less broken for those apps at least. As far as I can tell it doesn't break anything

@tintou
Copy link
Member

tintou commented Aug 13, 2025

Every time that I report it, the app get fixed in a few days, I'm not sure that we are doing anything good with the ecosystem to apply this workaround just for us

@danirabbit
Copy link
Member

@tintou hm yeah maybe you're right. If you want to add a PR to revert with that reasoning, I guess I'll revert. And we should probably add a comment to the theme file about why we don't have inherits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants