Use Adwaita as a fallback icon theme #1365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if no fitting icon is found in elementary icon theme, gtk falls back to
hicolor, as per the fd.o spec. With this PR, it will first try to find missing icon in Adwaita (which is present in elementary OS) before resorting to displaying a missing icon image. This issue mainly affects GNOME Circle apps that heavily rely on Adwaita, and while it is recommended to bundle all non-fd.o icons, not all apps do so (unfortunately).Before/after examples (Apostrophe and Ptyxis):