Redesign changes-allow #1372
Merged
Redesign changes-allow #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
reviewed
Sep 25, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
I do agree this shape is easier to tell the difference in states. I wonder if we can make the angle the shank is hanging at slightly less dead on so that we can avoid moving the padlock body as much as possible?
danirabbit
approved these changes
Oct 31, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Gonna go ahead and merge this since we have some broken symlinks currently in main and we can always revisit this later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third and final pull request split from #1369. It contains the icon I submitted as
unlocked.svgin #1369, but this time as a redesign ofchanges-allow, which I wasn’t aware already existed.The new design has the advantage of being more visually distinct from the
lockedicon, especially at small sizes.