Skip to content

Persist conversation list filter switches #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 2 commits into from
Nov 12, 2025
Merged

Persist conversation list filter switches #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f43d57
Persist conversation list filter switches
lobre Nov 8, 2025
3c90db2
Merge branch 'master' into persist-conversation-filters
danirabbit Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added data/gschemas.compiled
View file
Open in desktop
Binary file not shown.
11 changes: 10 additions & 1 deletion data/io.elementary.mail.gschema.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,16 @@
<summary>Whether to always load remote images without prompting</summary>
<description>Whether to always load remote images without prompting</description>
</key>
<key name="hide-read-conversations" type="b">
<default>false</default>
<summary>Whether to hide read conversations in the list</summary>
<description>Stores the last used state of the “Hide read conversations” filter</description>
</key>
<key name="hide-unstarred-conversations" type="b">
<default>false</default>
<summary>Whether to hide unstarred conversations in the list</summary>
<description>Stores the last used state of the “Hide unstarred conversations” filter</description>
</key>
<key name="remote-images-whitelist" type="as">
<default>[]</default>
<summary>A list of sender addresses for which remote images will be automatically loaded</summary>
Expand All @@ -51,4 +61,3 @@
</key>
</schema>
</schemalist>

8 changes: 5 additions & 3 deletions src/ConversationList/ConversationList.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ public class Mail.ConversationList : Gtk.Box {
};

hide_read_switch = new Granite.SwitchModelButton (_("Hide read conversations"));

hide_unstarred_switch = new Granite.SwitchModelButton (_("Hide unstarred conversations"));

var filter_menu_popover_box = new Gtk.Box (VERTICAL, 0) {
Expand Down Expand Up @@ -203,8 +202,11 @@ public class Mail.ConversationList : Gtk.Box {
}
});

hide_read_switch.toggled.connect (() => load_folder.begin (folder_info_per_account));
var settings = new GLib.Settings ("io.elementary.mail");
settings.bind ("hide-read-conversations", hide_read_switch, "active", DEFAULT);
settings.bind ("hide-unstarred-conversations", hide_unstarred_switch, "active", DEFAULT);

hide_read_switch.toggled.connect (() => load_folder.begin (folder_info_per_account));
hide_unstarred_switch.toggled.connect (() => load_folder.begin (folder_info_per_account));
}

Expand All @@ -222,7 +224,7 @@ public class Mail.ConversationList : Gtk.Box {
}
}

public async void load_folder (Gee.Map<Backend.Account, Camel.FolderInfo?> folder_info_per_account) {
public async void load_folder (Gee.Map<Backend.Account, Camel.FolderInfo?> folder_info_per_account) requires (folder_info_per_account != null) {
lock (this.folder_info_per_account) {
this.folder_info_per_account = folder_info_per_account;
}
Expand Down