Mainwindow: absorb search bar

[danirabbit]

Can be rebase merged if desired.

Cleanups:

• Entries shouldn't use tooltip, they have placeholder for this purpose. Use the more descriptive placeholder
• activate_entry is only called by the action so search text is never used
• don't connect signals in a separate function. Let's us scope down variables
• Organize and remove commented code

Absorb into mainwindow

• We can't subclass SearchEntry in GTK4. We could put it in a bin, but it needs access to a lot of things in Window anyways, so this is much simpler than reaching across classes for access
• Search entry can be private here, its not accessed outside this class

[stsdc]

• Tooltip: The tooltip was there basically to make a key combination discoverable. Are we sure, we want to remove it?
• Search.vala : In the GTK4 PR the SearchEntry is wrapped in Gtk.Box (i know should be a Bin). But I'm still in favour of keeping it in a separate class to contain this filter func and other objects.

[danirabbit]

The tooltip was there basically to make a key combination discoverable. Are we sure, we want to remove it?

Yeah it's not expected for text entries or other labeled widgets to have tooltips. Tooltips should really only be for things that don't already have labels like image buttons

But I'm still in favour of keeping it in a separate class to contain this filter func and other objects

What do you think about moving the filter func etc into ProcessView? I think that would improve encapsulation. I really don't like how much has to be publicly exposed with the search.vala class

[stsdc]

Yeah, I think this is a good solution. 👍