Statusbar: cleanup and GTK4 prep #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danirabbit
commented
Sep 23, 2025
danirabbit
commented
- Explicitly scope variables
- Initialize properties with objects
- Remove version number, github link, Ukraine badge. App information is in metainfo. Definitely stand with Ukraine but we don't include this kind of messaging in any of our apps
- Use built-in format tools for swap size so we're not manually translating units
- Make sure "N/A" is translatable
- Statubar can't be subclassed in GTK4, so put it in a bin
Member
|
lgtm |
Member
|
But to be honest, I think statusbar is a candidate for a complete removal in the future. |
stsdc
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.