Skip to content

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Sep 25, 2025

Can be rebase merged if desired. GTK4 prep, cleanups

  • set margin in usage-label-container CSS. You must ninja clean to rebuild CSS
  • set_main_chart ()main_chart property
  • Initialize widgets in construct block
  • Replace Grid with Overlay and Box where appropriate
  • Code style. Explicitly set margins
  • Replace ToggleButton with MenuButton

LabelVertical is only used inside WidgetResource, so absorb it there

  • Clicked signal is never used
  • Use a box instead of a grid
  • css class is never used
  • label_vertical_main_metricmain_metric_value

@danirabbit danirabbit requested a review from a team September 25, 2025 18:35
Copy link
Member

@stsdc stsdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@stsdc stsdc merged commit 822cc06 into main Sep 26, 2025
4 checks passed
@stsdc stsdc deleted the danirabbit/widgetresource-cleanup branch September 26, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants