Skip to content

ProcessView: reduce object access, build ui in construct #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

ProcessView: reduce object access, build ui in construct #464

merged 1 commit into from
Sep 30, 2025

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Sep 30, 2025

  • If things have to be publicly gettable, make sure they're private set
  • process_info_view doesn't seem to need to be public
  • use construct block since nothing is a construction argument
  • initialize properties with objects

@danirabbit danirabbit requested a review from a team September 30, 2025 20:15
@danirabbit danirabbit mentioned this pull request Sep 30, 2025
Merged
@danirabbit danirabbit merged commit 7b59366 into main Sep 30, 2025
4 checks passed
@danirabbit danirabbit deleted the danirabbit/processview-cleanup branch September 30, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenemter lenemter lenemter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danirabbit @lenemter