Skip to content

Move metadata discovery to AudioObject #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Move metadata discovery to AudioObject #697

wants to merge 1 commit into from

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 21, 2022

Fixes #693

  • Discover metadata whenever an AudioObject is created
  • PlaybackManager only handles playback now
  • When discoverer returns metadata, more easily check which object it's for

@danirabbit danirabbit marked this pull request as draft January 22, 2022 00:00
@danirabbit
Copy link
Member Author

danirabbit commented Jan 22, 2022

Getting a bug here with playback position. Probably because track length is being discovered after we clamp position

@danirabbit danirabbit mentioned this pull request Aug 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move Metadata Discoverer to AudioObject?

2 participants

@danirabbit