Skip to content

Conversation

@Oowoosh0
Copy link
Contributor

Adds a button to remove all elements from the queue.
One of the features requested in #779
music-clear-queue

@Oowoosh0
Copy link
Contributor Author

Just noticed that it would make sense to hide the button if the queue is already empty. I'm doing to add that.

@danirabbit
Copy link
Member

hide the button if the queue is already empty

@Oowoosh0 Instead of this, you should disable the action and it'll automatically make the button insensitive and ignore any future keyboard shortcuts :)

@Oowoosh0
Copy link
Contributor Author

Oowoosh0 commented Mar 19, 2025

the action is now disabled when no items are in the queue.
The disabled buttons background is automatically slightly darker and has an inset box-shadow. Even though the style class is flat. I don't know if that is intended by the elementary stylesheet or if that is a bug. I think the box-shadow looks a bit odd in dark-mode.
music-clear-2

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I see what you mean with the styling. That's definitely a stylesheet bug and not anything for you to fix here

@danirabbit danirabbit enabled auto-merge (squash) March 19, 2025 22:50
@danirabbit danirabbit merged commit d0bcd78 into elementary:main Mar 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants