Skip to content

Conversation

@leolost2605
Copy link
Member

Fixes #794

Introduce a search bar widget since we are probably gonna need search in more places if we're going to implement the library.

@leolost2605 leolost2605 requested a review from a team March 25, 2025 20:58
Copy link
Contributor

@Oowoosh0 Oowoosh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me. Just a couple of smaller issues I found:

  • When nothing matches the search term then the "Queue is Empty" Placeholder gets shown. Probably it would be better to display a placeholder here that reflects that the search didn't return any results.
  • There are some performance issues if the queue is larger (couple hundred songs). The UI freezes for a bit on every character entered into the search bar. I guess it is unavoidable that filtering a longer list takes a bit, but ideally the UI should stay responsive.
  • If I clear the queue while a search is applied and then add new songs that search is automatically applied again. Maybe it's better to reset the search filter when clearing the queue. But I'm not really sure which of the two would be the expected behaviour for most people.

@danirabbit danirabbit mentioned this pull request Aug 13, 2025
3 tasks
@danirabbit danirabbit requested a review from Oowoosh0 August 13, 2025 18:39
@danirabbit
Copy link
Member

@Oowoosh0 Pushed a couple commits to address review comments. I think performance should be better here since we've switched to ListView previously

@danirabbit danirabbit requested a review from ryonakano August 15, 2025 18:56
@danirabbit danirabbit requested a review from ryonakano August 27, 2025 19:54
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I think it would be more natural if the placeholder text changes according with typing in search entry 🤔

image

@danirabbit danirabbit requested a review from ryonakano August 30, 2025 15:54
@danirabbit
Copy link
Member

@ryonakano fixed!

@danirabbit danirabbit merged commit 1f0c6fc into main Aug 31, 2025
3 checks passed
@danirabbit danirabbit deleted the leolost/search-bar branch August 31, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search function only shows first occurrence of search term.

5 participants