Correctly display artists name in NowPlayingView #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
approved these changes
Apr 3, 2025
Collaborator
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
The artist name now ellipsizes and reveals as expected. The window does not change size. Code looks good.
One issue I noticed is that now, if the artist name is ellipsized, making the window wider does not give it more space - you have to drag the pane divider to do so. To fix this you need to set resize_end_child = true on the enclosing Gtk.Paned. Then the ratio between the widths of the two children stays constant when the window expands. However, I think this is outside the strict scope of this PR and may need design input so can be left for another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #803