Restore last played #814
Merged
Restore last played #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
requested changes
Aug 13, 2025
Co-authored-by: Danielle Foré <[email protected]>
Co-authored-by: Danielle Foré <[email protected]>
danirabbit
reviewed
Aug 14, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
This looks pretty clean to me! Just a couple small comments and I'll build and test and we can get this merged. Nice work!
danirabbit
approved these changes
Aug 15, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
This looks great and works as expected. Nice job! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #792
approach: Just like restoring Queue, restoring last played is playback's problem
We remember the URI of last played track. If it still exists, we search for it in restored queue, retrieve the object and slam it in currently playing
Next and Previous go from the restored "last played". I thought i had to update playback_position but it does not seem needed.
I had issues with the liststore to retrieve position, so i reused the code for searching. This could be improved upon.
NowPlayingView caused issues. The binds for labels and image were very unreliable, so this has been changed to simply setting the variables on signal.