Skip to content

Add accel to open files via Ctrl+O #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 15, 2025
Merged

Add accel to open files via Ctrl+O #820

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8573270
Add accel to open files via ctrl+O
teamcons Aug 11, 2025
5c5e8a6
Merge branch 'main' into add-open-accel
ryonakano Aug 13, 2025
4540b52
Merge branch 'main' into add-open-accel
ryonakano Aug 14, 2025
b54c496
action-open as an action of MainWindow
ryonakano Aug 14, 2025
23f9175
Merge pull request #2 from ryonakano/add-open-accel-suggestion
teamcons Aug 14, 2025
ae8d539
Do not keep track of the SimpleAction. Let it mind its business.
teamcons Aug 14, 2025
9ca310c
Merge branch 'main' into add-open-accel
teamcons Aug 14, 2025
249e60d
Oops
teamcons Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/MainWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
*/

public class Music.MainWindow : Gtk.ApplicationWindow {
private const string ACTION_PREFIX = "win.";
private const string ACTION_OPEN = "action-open";

private Granite.Placeholder queue_placeholder;
private Gtk.Button repeat_button;
private Gtk.Button shuffle_button;
Expand All @@ -14,6 +17,7 @@ public class Music.MainWindow : Gtk.ApplicationWindow {
private Gtk.SingleSelection selection_model;
private Gtk.Stack queue_stack;
private Settings settings;
private SimpleAction open_action;

construct {
var playback_manager = PlaybackManager.get_default ();
Expand Down Expand Up @@ -78,8 +82,12 @@ public class Music.MainWindow : Gtk.ApplicationWindow {
add_button_box.append (new Gtk.Image.from_icon_name ("document-open-symbolic"));
add_button_box.append (add_button_label);

open_action = new SimpleAction (ACTION_OPEN, null);
open_action.activate.connect (open_files);

var add_button = new Gtk.Button () {
child = add_button_box,
action_name = ACTION_PREFIX + ACTION_OPEN
};
add_button.add_css_class (Granite.STYLE_CLASS_FLAT);

Expand Down Expand Up @@ -176,6 +184,11 @@ public class Music.MainWindow : Gtk.ApplicationWindow {

update_repeat_button ();

unowned var app = ((Gtk.Application) GLib.Application.get_default ());
app.set_accels_for_action (ACTION_PREFIX + ACTION_OPEN, {"<Ctrl>O"});

add_action (open_action);

drop_target.drop.connect ((target, value, x, y) => {
if (value.type () == typeof (Gdk.FileList)) {
var list = (Gdk.FileList)value;
Expand All @@ -202,8 +215,6 @@ public class Music.MainWindow : Gtk.ApplicationWindow {
error_toast.send_notification ();
});

add_button.clicked.connect (action_open);

repeat_button.clicked.connect (() => {
var enum_step = settings.get_enum ("repeat-mode");
if (enum_step < 2) {
Expand Down Expand Up @@ -251,7 +262,7 @@ public class Music.MainWindow : Gtk.ApplicationWindow {
}
}

private void action_open () {
private void open_files () {
var all_files_filter = new Gtk.FileFilter () {
name = _("All files"),
};
Expand Down