Skip to content

Add support for sound-name and suppress-sound hints #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add support for sound-name and suppress-sound hints #124

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b4d0b3a
Add support for sound-name and suppress-sound hints
bluesabre May 23, 2021
a670774
Add category and libnotify notifications
bluesabre May 26, 2021
6995571
Add sound-name demo
bluesabre May 26, 2021
b3aabfa
Add suppress-sound demo
bluesabre May 26, 2021
dcbac47
Center libnotify label
bluesabre May 26, 2021
b176de2
Add libnotify-dev to GH workflow
bluesabre May 26, 2021
cfe4bb2
Merge branch 'master' of github.com:elementary/notifications into sou…
bluesabre Jun 2, 2021
df01e81
Merge branch 'master' into sound-hints
bluesabre Jul 9, 2021
94fc653
Merge branch 'master' into sound-hints
bluesabre Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/DBus.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,16 @@ public class Notifications.Server : Object {
}

private void send_sound (HashTable<string,Variant> hints, string sound_name = "dialog-information") {
unowned Variant? variant = null;

if ((variant = hints.lookup ("suppress-sound")) != null && variant.is_of_type (VariantType.BOOLEAN) && variant.get_boolean ()) {
return;
}

if (sound_name == "dialog-information") {
Variant? variant = hints.lookup ("category");
if (variant != null) {
if ((variant = hints.lookup ("sound-name")) != null && variant.is_of_type (VariantType.STRING)) {
sound_name = variant.get_string ();
} else if ((variant = hints.lookup ("category")) != null && variant.is_of_type (VariantType.STRING)) {
sound_name = category_to_sound_name (variant.get_string ());
}
}
Expand Down