Skip to content

Records (all) Applications that Send Notifications #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Records (all) Applications that Send Notifications #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
470e237
Recorded applications that send notifications.
chrisdotcode Feb 2, 2022
0fea559
Merge branch 'master' into master
Mar 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions data/notifications.gschema.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<schemalist>
<schema path="/io/elementary/notifications/" id="io.elementary.notifications">
<key type="as" name="applications">
Copy link

@jeremypw jeremypw Mar 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same name as an existing subfolder which might be confusing. Not sure what a better name would be. Maybe "notifying-applications"?

<default>[]</default>
<summary>Applications that have sent notifications. Used in the switchboard</summary>
</key>
<key type="b" name="do-not-disturb">
<default>false</default>
<summary>Disable all notifications</summary>
Expand All @@ -24,5 +28,9 @@
<default>true</default>
<summary>Show missed notifications in notification center</summary>
</key>
<key type="b" name="has-app">
<default>true</default>
<summary>Does a corresponding .desktop entry file exist</summary>
</key>
</schema>
</schemalist>
6 changes: 6 additions & 0 deletions src/DBus.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,12 @@ public class Notifications.Server : Object {
} else {
var notification = new Notifications.Notification (app_name, app_icon, summary, body, actions, hints);

var apps = settings.get_strv("applications");
if (!(notification.app_id in apps)) {
apps += notification.app_id;
settings.set_strv("applications", apps);
}

if (!settings.get_boolean ("do-not-disturb") || notification.priority == GLib.NotificationPriority.URGENT) {
var app_settings = new GLib.Settings.full (
SettingsSchemaSource.get_default ().lookup ("io.elementary.notifications.applications", true),
Expand Down