Play dialog-question sound upon dialog present

[vjr]

No description provided.

[vjr]

I guess 3863b34 means the deb-packaging branch needs to add Canberra in there too?

[vjr]

Can anyone look at this PR (or maybe even the codebase/config/meson/settings etc) and tell me what I'm missing here?

What happens is unless I also set PROP_APPLICATION_LANGUAGE or PROP_MEDIA_LANGUAGE to any value (valid locale, random string, blank too) there are some sounds that don't play. The play () method returns -9 aka FILE_NOT_FOUND error which is perplexing me.

It plays most other sounds from different sound themes if I specify them except for those it decides it doesn't want to. Interesting thing is, if I copy the dialog-question.oga file to a different name say polkit-question.oga then it works. I looked through the libcanberra source code from the noble apt source for it and couldn't see anything of interest there.

I've downloaded the KDE neon ocean sound theme on my OS8 installation from https://archive.neon.kde.org/user/pool/main/o/ocean-sound-theme/

Any ideas? Thanks!

[danirabbit]

@vjr not sure if this solves your issues but we've been adding this canberragtk4 class in other projects: https://github.com/elementary/switchboard-plug-sound/blob/main/src/CanberraGtk4.vala

[vjr]

@vjr not sure if this solves your issues but we've been adding this canberragtk4 class in other projects: https://github.com/elementary/switchboard-plug-sound/blob/main/src/CanberraGtk4.vala

This commit seems to get the sounds to play -> 1bee580 - hope it's an acceptable work around.

[jeremypw]

@vjr this does not seem to honor the sound settings ("org.gnome.desktop.sound")? I think it should (Files for example does - see SoundManager.vala). @danirabbit Is this OK UX-wise? Its not linked to an issue.

[vjr]

hi @jeremypw ! thanks for looking into this PR - are you saying i need to check if the event-sounds flag is true only then play the sound, just like Files does? i can update this PR for that - might be this weekend though.

[vjr]

@jeremypw does the latest commit 25f5412 address your comment to honour the event-sounds sound setting?

[jeremypw]

The code looks sane in principle but I could not get any sound when testing on a VM, although Files trash deletion, which uses similar code, does produce the expected sound. I tried a few things but so far no luck.

[vjr]

The code looks sane in principle but I could not get any sound when testing on a VM, although Files trash deletion, which uses similar code, does produce the expected sound. I tried a few things but so far no luck.

@jeremypw does your VM installation actually have a dialog-question (.ogg or oga or an audio extenstion) file in /usr/share/sounds/elementary/stereo or its fallback sound theme location /usr/share/sounds/freedesktop/stereo? IIRC I had copied the file from the KDE ocean sound theme to test this PR.

If the current OS packages do not include that file this PR simply wont play the sound (current/old behaviour) and when this file is included in the elementary sound theme package it will.

[vjr]

dialog-question.oga.gz

@jeremypw i've attached the file in question for you to try, if you place it in /usr/share/sounds/elementary/stereo and try the PR again? thanks!

[jeremypw]

@vjr I tried that with no success I am afraid (I had already tried changing the code to use the same sound as Files which I knew worked. I have checked that event-sounds is enabled in the settings. Notifications send from Terminal play a sound OK. So its a bit of a puzzle.

[vjr]

@vjr I tried that with no success I am afraid (I had already tried changing the code to use the same sound as Files which I knew worked. I have checked that event-sounds is enabled in the settings. Notifications send from Terminal play a sound OK. So its a bit of a puzzle.

Yes, puzzling - see #85 (comment) and #85 (comment) - if you notice anything amiss?

[vjr]

Note to self, see elementary/notifications#264