Start implementing Notification Portal v2 #152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start implementing Notification Portal v2. Implements very very simple notifications portal which currently only supports title, body, body-markup and priority. It converts portal notification requests into fdo notification calls that our notification server can understand.
It is currently impossible to implement this portal inside the notification server itself because portals need to be launched by systemd, but our notification server need to be launched by gala. But in the future we definitely can merge these two.
Implementing full portal spec in one branch is almost impossible since the spec is insanely big. If we decide to merge this I'll create an issue to track what we need to implement next.
You can test this branch using ASHPD Demo
Based on #128