ShortcutsView: rewrite for screen reader #151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You seem to include multiple changes in this PR:
While 2. could be company with 1. if you would, I think you should separate 3. in another PR at least because this should nothing related to 1. |
ryonakano
reviewed
May 14, 2025
| gresource, | ||
| config_file, | ||
| dependencies: [ | ||
| dependency('glib-2.0'), |
Member
There was a problem hiding this comment.
I couldn't comment on the actual line, but we now require granite-7 >= 7.3.0 because of automatic load of Application.css:
We should explicit it in the meson.build and README.
| screenshots_box.append (screenshots_listbox); | ||
|
|
||
| screenshots_listbox.append (new NameLabel (_("Grab the whole screen"), new ShortcutLabel.from_gsettings (SCHEMA_GALA, "screenshot"))); | ||
|
|
Member
There was a problem hiding this comment.
This newline causes an orphan maybe unintentionally?
Co-authored-by: Ryo Nakano <[email protected]>
This was referenced May 14, 2025
Merged
Member
Author
|
@ryonakano I broke this up into a few different branches that should be easier to review: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150
In this way, the screen reader will announce for example "System, list with 6 items". Each shortcut can be navigated with the keyboard and read aloud