ShortcutsView: use listboxes #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
force-pushed
the
danirabbit/screenreader
branch
from
c63fb9e to
9820548
Compare
ryonakano
reviewed
May 17, 2025
ryonakano
reviewed
May 20, 2025
ryonakano
approved these changes
May 20, 2025
Member
ryonakano
left a comment
ryonakano
left a comment
There was a problem hiding this comment.
Thank you for a11y improvements and separating these PRs ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150
Uses listboxes instead of a grid. In this way, the screen reader will announce for example "System, list with 6 items". Each shortcut can be navigated with the keyboard and read aloud