Skip to content

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Jul 8, 2025

  • label.heading is used by Gtk.PopoverMenu so only style it when its in a popover.menu node.
  • header is the node used by Granite.HeaderLabel so replace this in popover to avoid regressions
  • Make sure we clear indentation on header label.heading (the primary label in a Granite.HeaderLabel` so we don't end up with double indentation

BEFORE

Screenshot from 2025-07-08 09 55 08

AFTER

Screenshot from 2025-07-08 09 58 59

@danirabbit danirabbit requested a review from a team July 8, 2025 16:59
@danirabbit danirabbit moved this to Needs review in OS 8.1.0 Jul 8, 2025
@wpkelso wpkelso merged commit e39dcd7 into main Jul 8, 2025
3 checks passed
@wpkelso wpkelso deleted the danirabbit/popover-headings branch July 8, 2025 18:13
@github-project-automation github-project-automation bot moved this from Needs review to Done in OS 8.1.0 Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

The primary text in Granite.HeaderLabel misaligned when placed in Gtk.Popover

3 participants