Adding timeout to clear the search field #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
requested changes
Oct 22, 2024
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
This also happens if you use the clear button. So maybe what would be better would be to add the timeout in the search changed handler before we call invalidate_filter?
Member
|
Also don't forget to update metainfo with the bugfix line please :) |
Member
Author
|
I found a better way to fix it. |
danirabbit
approved these changes
Oct 22, 2024
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Clean! love not having to rely on a timeout too. Good job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #182