Skip to content

Conversation

@leolost2605
Copy link
Member

Another version of #336 that does things differently. It now doesn't break API nor will it require plugs to set a name for pages they add to the stack.

Still it fixes all the problems that would've been fixed by #336:

  • If we click a search result without having opened the corresponding plug first the correct page will be preselected (e.g. when you search dock the dock page will be preselected instead of the first page as it is on main).
  • The selected row in the sidebar now always matches the visible child

@leolost2605 leolost2605 requested a review from a team March 15, 2025 12:39
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is improvement and issue still fixed.

@jeremypw jeremypw merged commit 150ef81 into main Mar 18, 2025
4 checks passed
@jeremypw jeremypw deleted the leolost/fix-row-selection-v2 branch March 18, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants