Skip to content

Conversation

@ryonakano
Copy link
Member

@ryonakano ryonakano commented Jul 29, 2025

Fixes the following build warning:

../lib/PlugsManager.vala:80.42-80.54: warning: `GLib.Module.SUFFIX' has been deprecated since 2.76
   80 |                     if (path.has_suffix (Module.SUFFIX)) {
      |                                          ^~~~~~~~~~~~~

GLib.Module.open() detects files that are not a shared library these days as written in the original C source code:

https://gitlab.gnome.org/GNOME/glib/-/blob/2.80.0/gmodule/gmodule.c?ref_type=tags#L87-108
https://gitlab.gnome.org/GNOME/glib/-/blob/2.80.0/gmodule/gmodule.c?ref_type=tags#L429-464

You can test this branch by the following steps:

user@elementary-daily:~$ cat dummy.vala
public static int main (string[] args) {
    return 0;
}
user@elementary-daily:~$ valac ./dummy.vala
user@elementary-daily:~$ sudo mv dummy /usr/lib/aarch64-linux-gnu/switchboard-3/system/libdummy.so
user@elementary-daily:~$ io.elementary.settings

(io.elementary.settings:5374): Gtk-WARNING **: 22:45:42.402: Theme parser error: Granite.css:1:1-6: Unknown name of pseudo-class

(io.elementary.settings:5374): Gtk-WARNING **: 22:45:42.431: Theme parser error: Granite-dark.css:1:1-6: Unknown name of pseudo-class

(io.elementary.settings:5374): switchboard-CRITICAL **: 22:45:42.512: PlugsManager.vala:50: /usr/lib/aarch64-linux-gnu/switchboard-3/system/libdummy.so: cannot dynamically load position-independent executable

@ryonakano ryonakano requested a review from a team July 29, 2025 13:51
@ryonakano ryonakano marked this pull request as draft July 29, 2025 13:52
@ryonakano

This comment has been minimized.

@ryonakano ryonakano marked this pull request as ready for review July 29, 2025 22:34
@ryonakano ryonakano enabled auto-merge (squash) August 9, 2025 23:27
@ryonakano ryonakano merged commit 784cf87 into main Aug 9, 2025
4 checks passed
@ryonakano ryonakano deleted the ryonakano/fix-warnings-gmodule branch August 9, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants