TerminalWidget: Use the non-deprecated spawn API #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
If run on OS7.1 this seems to cause the whole session to crash when the terminal window is closed. It runs OK on OS8 though. |
Collaborator
|
The problem is caused by an incorrect signature for |
jeremypw
reviewed
Nov 24, 2024
| } | ||
| ); | ||
|
|
||
| check_cwd_changed (); |
Collaborator
There was a problem hiding this comment.
Shouldn't this be inside the callback?
jeremypw
reviewed
Nov 24, 2024
| -1, | ||
| null, | ||
| (terminal, pid, error) => { | ||
| if (pid != -1) { |
Collaborator
There was a problem hiding this comment.
Better to check error == null since the else clause dereferences error?
Collaborator
|
The Gtk4 port branch uses the non-deprecated async version of spawn and is close to completion so probably not worth completing this branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.