Change tabs with keypad numbers #848
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryonakano
reviewed
Sep 1, 2025
Comment on lines
+480
to
+482
| if (keyval > 48 + 8) { | ||
| keyval -= (Gdk.Key.KP_1 - Gdk.Key.@1); | ||
| } |
Member
There was a problem hiding this comment.
I think this is hacky (honestly we should create a new method here) but that's out of scope of this PR.
Collaborator
Author
|
@ryanoko I am concentrating on the Gtk4 port at the moment as it is fairly near completion. So I am reluctant to add new features if they can wait. There is also the unresolved issue of how to expose the tab numbers. The current solution(#849) is rather crude. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arising from #655
In some locales changing the tabs using
Alt + numberdoes not work using the keyboard numerals. This PR enables the keypad numerals to be used instead.