Fix some problems running commands from the commandline. #930
+16
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
added
the
Status: Blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #929
Fixes #311 (afaict)
Instead of spawning the requested program directly with Vte (which automatically creates a shell to run it in), we create the shell as usual and then feed the command in as if typed at the commandline. This leads to more predictable results and the shell does not exit with its child.
It is also now possible to run a sequence of commands in the same tab without using a script by separating them with semi-colons and enclosing in quotes:
io.elementary.terminal -e "command1;command2;command3"This PR arises from the discussion at #926