Skip to content

Conversation

@wpkelso
Copy link
Member

@wpkelso wpkelso commented Jul 18, 2025

Related: elementary/hig#54

Changes Summary

  • Duplicated relevant icons from the icons repo
  • Remade examples with current icons

This pull request is ready for review.

Linked with elementary/hig#62

@wpkelso wpkelso requested a review from a team July 18, 2025 19:56
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It looks like contrast-example2.png is the wrong size of image. The goal of this section is to show the stroke style and it looks like we overlay a grid. The replacement image here has strokes that are half as wide as the original image. I'm guessing that the 128px image was exported at 4x here in the replacement, but it's probably 64px @ 8x in the original
  • in example-icon1.png, the text here is about showing the concept of the "mean line" across different icons with different x heights. The arrow in the replacement icon no longer aligns on this mean line, so it makes the accompanying text not make sense. We probably should just get rid of this "mean line" section since I don't think we really adhere to that anymore, but either way this replacement image doesn't really make sense here
  • We're missing the replacements for shadow-example1.png etc that go with the updated Music icon. I'm okay with not updating this if you intend to remove that section in anticipation of elementary/icons#1353

@wpkelso
Copy link
Member Author

wpkelso commented Jul 22, 2025

@danirabbit Yes, shadow-example1.png was left as-is in anticipation of the shadow's removal. Currently, elementary/icons#1362 exists to solidify that, but as it's not been merged yet, I've left the shadows in all the icons updated here.

I wasn't intending to fully remove sections yet, just leave them as vestigial here and come back to them later, but perhaps it's better to change the coolant while we're changing the oil, so to speak. I can make a proposal to remove/deprecate relevant sections from the HIG.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this now, and then yeah I think we should probably remove the section about the "mean line" as a follow up

@danirabbit danirabbit merged commit 01ad31b into master Jul 22, 2025
5 checks passed
@danirabbit danirabbit deleted the wpkelso/update-icons branch July 22, 2025 22:17
@danirabbit
Copy link
Member

Thanks for updating these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants