Skip to content

Conversation

@lenemter
Copy link
Member

@lenemter lenemter commented Sep 2, 2023

Complementary to elementary/greeter#684

@lenemter lenemter marked this pull request as ready for review January 27, 2024 12:06
@lenemter lenemter requested a review from a team January 27, 2024 12:06
@lenemter lenemter added the Blocked Something else needs to be done before this can be fixed label Jan 30, 2024
@lenemter lenemter mentioned this pull request Jan 31, 2024
2 tasks
Copy link
Member

@davidmhewitt davidmhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably isn't going to work in the expected way, or at all.

The Granite.Settings object first queries the Portal, which probably isn't running in the greeter. Then it queries AccountsService, which is running, but Granite queries using the current user (which is lightdm in the greeter session).

There's also a chance of hangs here because a lot of these DBus calls happen synchronously.

I would suggest that instead of this, the Greeter needs to communicate the dark style preference to the panel, rather than the panel process trying to detect it itself in the Greeter.

@lenemter
Copy link
Member Author

lenemter commented Jan 31, 2024

@davidmhewitt elementary/greeter#684 both launches portals in the greeter session and syncs dark style preference from selected user's AccountsService to lightdm's one.

@lenemter lenemter marked this pull request as draft August 12, 2024 03:23
@lenemter lenemter closed this May 9, 2025
@lenemter lenemter deleted the remove-greeter-workaround branch May 9, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked Something else needs to be done before this can be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants