Skip to content

Conversation

@lagoshny
Copy link
Contributor

@lagoshny lagoshny commented Mar 7, 2025

Changed condition to define right actual panel height with scale factor to prevent the overlay panel to other window in full mode.

Fixes #594

@leolost2605
Copy link
Member

The thing is this breaks when fractional scaling is enabled on wayland :\

For me the current version works on wayland both with

  • fractional scaling
  • 'normal' scaling i.e. 100 and 200 only i.e. physical layout

although it does require a wingpanel restart after scaling changed which definitely is something that can be optimized.

What combination would require this change? (X, wayland fractional or wayland not fractional)
Btw fractional is enabled when you add scale-monitor-framebuffers to the org.gnome.mutter.experimental-features dconf key

@lagoshny
Copy link
Contributor Author

lagoshny commented Mar 8, 2025

This is necessary for the X11 Display.
This behavior was the default until the wayland condition was added.

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok then you should probably just remove the condition because it shouldn't be always true on wayland.

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@leolost2605 leolost2605 merged commit b07e3ef into elementary:master Mar 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Half of the Wingpanel overlaps application windows

2 participants