Skip to content

chore(build): update versions #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 20, 2025
Merged

chore(build): update versions #31

merged 5 commits into from
Mar 20, 2025

Conversation

Nevoss
Copy link
Member

@Nevoss Nevoss commented Mar 20, 2025

No description provided.

@Nevoss Nevoss requested a review from Copilot March 20, 2025 13:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue where only the last Lighthouse test report persists by updating the removal target.

  • Changed the directory reference from a constant (OUTPUT_DIR) to a variable (outputPath) in the removal command.
Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

actions/run-lighthouse-tests/main.ts:107

  • Ensure that 'outputPath' is defined and correctly points to the intended directory. This change is critical to fix the report persistence issue by accurately cleaning up previous reports.
outputPath,

@Nevoss Nevoss changed the title fix(run-lighthouse-tests): only last report persists chore(build): update versions Mar 20, 2025
@Nevoss Nevoss merged commit d02dca0 into elementor:main Mar 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants