Internal: Update build and create NPM package [ED-7724]#70
Open
yotamselementor wants to merge 15 commits intomasterfrom
Open
Internal: Update build and create NPM package [ED-7724]#70yotamselementor wants to merge 15 commits intomasterfrom
yotamselementor wants to merge 15 commits intomasterfrom
Conversation
yotamselementor
changed the title
matipojo
suggested changes
Jul 28, 2022
.github/workflows/prerelease.yml
Outdated
| node-version: [16.x] | ||
|
|
||
| steps: | ||
| - uses: actions/github-script@v1 |
Member
There was a problem hiding this comment.
You are using many versions of this action (0.3.0, v1, v4) is there a reason for it? If so, please explain in code in comments.
Author
There was a problem hiding this comment.
The prerelease/release scripts should be reviewed/rewritten by @chenele & her team
matipojo
suggested changes
Jul 31, 2022
chenele
reviewed
Aug 14, 2022
chenele
reviewed
Aug 14, 2022
chenele
reviewed
Aug 14, 2022
Co-authored-by: chenele <86892806+chenele@users.noreply.github.com>
Co-authored-by: chenele <86892806+chenele@users.noreply.github.com>
Co-authored-by: chenele <86892806+chenele@users.noreply.github.com>
chenele
reviewed
Aug 14, 2022
.github/workflows/prerelease.yml
Outdated
| @@ -0,0 +1,66 @@ | |||
| name: pre-release | |||
There was a problem hiding this comment.
not sure we want this pre-release action on a public repository. everyone will be able to publish new packages, doesnt make much sense.
we need the pre-release appraoch as Manual action that will be executed on demand by developers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following: