Draft
Conversation
Fix/deg rates
Fix/deg rates
Add `update_stack_status` function (NatLabRockies#31)
Added example NatLabRockies#6, conversion efficiency
- added P_STD from scipy physical constants, which is 1 bar in Pascals - mods to calc_open_circuit_voltage() include updated p_cathode, split up partial pressures for hydrogen/oxygen according to Dalton's law. Issue NatLabRockies#63: Nernst equation was incorrect. This issue only became became apparent when adjusting cathode pressure. - changed E_cell calculation to use the correct partial pressures and replaced R+T with R*T. - Updated test_cell.py, test_stack.py, test_run_electrolyzer.py to account for the new model change. - Incomplete is test_run_lcoh.py. Need assistance to adjust lcoh_breakdown.
…ls, RESULTS, and lcoh_results changed with latest cell modification.
Issue NatLabRockies#61: Update Cathod Pressure to be 30bar
…lectrolyzer produced more h2.
…r to today's commercially available
…ing dt to stack_dict
Updating dryer loss and membrane thickness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening pull request but the changes are not complete