Update Endpoint configuration - #221
Merged
Merged
Conversation
1 task
renal128
force-pushed
the
add-conversation-endpoints
branch
from
July 26, 2026 07:25
e86eef6 to
4e03383
Compare
renal128
force-pushed
the
add-conversation-endpoints
branch
from
July 26, 2026 16:30
4e03383 to
f424281
Compare
renal128
force-pushed
the
add-conversation-endpoints
branch
2 times, most recently
from
July 26, 2026 16:59
2562ec9 to
8ff5864
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8ff5864. Configure here.
renal128
force-pushed
the
add-conversation-endpoints
branch
from
July 26, 2026 17:09
8ff5864 to
c7e0283
Compare
jacksonh
approved these changes
Aug 3, 2026
renal128
force-pushed
the
add-conversation-endpoints
branch
from
August 4, 2026 15:47
c7e0283 to
49d30e2
Compare
renal128
force-pushed
the
add-conversation-endpoints
branch
from
August 4, 2026 16:38
49d30e2 to
2b426ef
Compare
renal128
force-pushed
the
add-conversation-endpoints
branch
from
August 4, 2026 18:33
2b426ef to
0ad421c
Compare
Add Endpoints on ConversationConfig and wire them through TokenService and the connection managers. HTTP requests derive from a single apiBase; ws/wss endpoints stay explicit. Drop ConnectionConstants and the global apiEndpoint/websocketUrl overrides. Co-authored-by: Cursor <cursoragent@cursor.com>
renal128
force-pushed
the
add-conversation-endpoints
branch
from
August 4, 2026 19:23
0ad421c to
403fac6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This is a step towards getting rid of global SDK config.
EndpointsonConversationConfig: anapiBasefor HTTP calls (the conversation token URL derives from it, there will be more endpoints using it later), plus explicit voice and text WebSocket URLsDependencies→TokenService/WebSocketConnectionManager/WebRTCConnectionManagerConnectionConstantsand removeapiEndpoint/websocketUrlfrom globalElevenLabs.Configuration(loggingconfigureremains)Test plan
swift testStacked on #218.
Note
Medium Risk
Public API breaks for apps that customized endpoints via global
ElevenLabs.Configuration; connection and token URLs now depend on per-session config, though production defaults match prior behavior.Overview
Moves network targeting off global SDK config onto
ConversationConfig.endpointsvia a newEndpointstype (apiBase,voiceWebSocket,textWebSocket, defaulting to production). Token fetch, LiveKit voice connect, and text WebSocket URLs now read from that config throughDependencies,TokenService,WebRTCConnectionManager, andWebSocketConnectionManager.ElevenLabs.Configurationno longer exposesapiEndpoint/websocketUrl(loggingconfigureremains).ConnectionConstantsis removed; the conversation token HTTP URL is derived fromapiBase.TokenService/TokenServicingare simplified:fetchToken(for:)returns aStringinstead of aConnectionDetailsbundle with server URL and empty room fields.ConversationClientbuildsDependencies(endpoints: config.endpoints)when starting a session.README adds a Custom Endpoints example; tests cover defaults, overrides, token URL derivation, and preserving existing query items on text WebSocket URLs.
Reviewed by Cursor Bugbot for commit 403fac6. Bugbot is set up for automated code reviews on this repo. Configure here.