Simplify the Text vs Voice split and auth - #233
Open
renal128 wants to merge 2 commits into
Open
Conversation
renal128
force-pushed
the
sketch/conversation-auth
branch
2 times, most recently
from
August 23, 2026 15:00
2cb84c7 to
64020ee
Compare
renal128
force-pushed
the
sketch/conversation-auth
branch
from
August 23, 2026 20:31
d50939f to
e23333d
Compare
renal128
force-pushed
the
sketch/conversation-auth
branch
3 times, most recently
from
August 23, 2026 20:50
2de232e to
36b4dc2
Compare
… by transport. Co-authored-by: Cursor <cursoragent@cursor.com>
renal128
force-pushed
the
sketch/conversation-auth
branch
2 times, most recently
from
August 23, 2026 21:49
d85d96a to
a72eef5
Compare
4 tasks
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a72eef5. Configure here.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Voice goes through WebRTC, Text goes through Websocket.
Auth is transport-dependent - WebRTC and Websocket have different available auth methods (auth doc).
So the API was a bit awkward and the auth <> conversation type relationship wasn't properly enforced.
Now the API is cleaner:
startVoiceConversation(auth: ConversationAuth.Voice, ...)andstartTextOnlyConversation(auth: ConversationAuth.TextOnly, ...)methods that enforce the modality and auth matchTest plan
swift testswift test -Xswiftc -swift-version -Xswiftc 6swiftformat . --strict