Skip to content

Sheet: Prevent out-of-range cell navigation #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2025
Merged

Sheet: Prevent out-of-range cell navigation #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions src/Widgets/Sheet.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,17 +179,24 @@ public class Spreadsheet.Widgets.Sheet : Gtk.DrawingArea {
queue_draw ();
}

private void move (int line_add, int col_add) {
// Ignore key press to the outside of the sheet
if (selected_cell.line + line_add < 0 || selected_cell.column + col_add < 0) {
private void move (int line_add, int column_add) {
if (selected_cell == null) {
select (0, 0);
return;
}

if (selected_cell != null) {
select (selected_cell.line + line_add, selected_cell.column + col_add);
} else {
select (0, 0);
int line_after = selected_cell.line + line_add;
int column_after = selected_cell.column + column_add;

// Ignore key press to the outside of the sheet
if (line_after < 0 || line_after >= page.lines) {
return;
}
if (column_after < 0 || column_after >= page.columns) {
return;
}

select (line_after, column_after);
}

public void move_top () {
Expand Down