Fix Nextcloud WireGuard route generation - #42
Draft
kappisj wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
wg_modules.confwhenWG_ACCESS_NEXTCLOUDcontainswgpubWhy
The
wgbranch currently writescode-server-ext.conftoext_modules.conf. A WireGuard-only Nextcloud configuration can therefore expose the code-server routes on the public bridge listener.Fixes part of #35.
Impact
WG_ACCESS_NEXTCLOUD=wgnow keeps both Nextcloud and its code-server routes on the WireGuard listener.pubandwg,pubretain their intended public behavior.Validation
bash -n docker/compose/assets/web/web-services-configure.shwgand external output targetsgit diff --check