Skip to content

Conversation

@teamcons
Copy link
Collaborator

@teamcons teamcons commented May 16, 2025

Hi @dar5hak

-GTK4 Granite yohoho
-Added permission to notify because flatpak
-Removed the "set autostart" thingie because flatpak
-Removed the repositioning window thingie because wayland
-Removed the reliance on a py script for meson
-Removed libhandy wtf is that
-Added german
-Added a flathub manifest if you ever want
-split PO files into regular and extra
-changed some deprecated stuff in da metainfo
-Remove the old legacy code for much older settings
-changed icon organization to respect conventions

I saw the translations include the app name. Idk why but i decided to go along with it
Fixes: #85

@dar5hak
Copy link
Collaborator

dar5hak commented May 16, 2025

What in the name of Arceus 😮 First of all, huge thanks. This is a considerable effort and you singlehandedly carried it. Extremely grateful for that!

Secondly, give me till tomorrow. I'll review the PR.

It's not exactly unmaintained, but it's more of a "feature complete so I'm not adding stuff". But this modernization was long overdue. You're the best! ❤️

@teamcons
Copy link
Collaborator Author

Someone on the eOS discord mentioned to me they liked it but notifications didnt work ootb anymore
i was looking for simple apps to port to a more modern stack and well uh, badger was there.

@dar5hak
Copy link
Collaborator

dar5hak commented May 17, 2025

Yeah, I missed that discussion somehow. Sorry about that! Are you not using the Discord any more?

Comment on lines 198 to 204
// User may wonder why they get no notification
// Ok also this looks better
//var hey = new Gtk.Label (_ ("Make sure Do Not Disturb is not on")) {
// halign = Gtk.Align.START,
// margin_top = 6
//};
//append (hey);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea. Feel free to uncomment.

@teamcons
Copy link
Collaborator Author

Am not in the eOS server anymore no

@teamcons
Copy link
Collaborator Author

marks and scales are a bit wonky at start in certain languages

@dar5hak
Copy link
Collaborator

dar5hak commented May 17, 2025

Am not in the eOS server anymore no

Okay. If you need anything, feel free to DM me on Discord and I'll be happy to help. Same username.

@dar5hak dar5hak merged commit 0b52315 into elfenware:main May 17, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Did a GTK4 port

2 participants