-
Notifications
You must be signed in to change notification settings - Fork 15
Modern port #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modern port #86
Conversation
|
What in the name of Arceus 😮 First of all, huge thanks. This is a considerable effort and you singlehandedly carried it. Extremely grateful for that! Secondly, give me till tomorrow. I'll review the PR. It's not exactly unmaintained, but it's more of a "feature complete so I'm not adding stuff". But this modernization was long overdue. You're the best! ❤️ |
|
Someone on the eOS discord mentioned to me they liked it but notifications didnt work ootb anymore |
|
Yeah, I missed that discussion somehow. Sorry about that! Are you not using the Discord any more? |
src/MainGrid.vala
Outdated
| // User may wonder why they get no notification | ||
| // Ok also this looks better | ||
| //var hey = new Gtk.Label (_ ("Make sure Do Not Disturb is not on")) { | ||
| // halign = Gtk.Align.START, | ||
| // margin_top = 6 | ||
| //}; | ||
| //append (hey); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great idea. Feel free to uncomment.
Co-authored-by: Darshak Parikh <[email protected]>
Co-authored-by: Darshak Parikh <[email protected]>
|
Am not in the eOS server anymore no |
|
marks and scales are a bit wonky at start in certain languages |
Okay. If you need anything, feel free to DM me on Discord and I'll be happy to help. Same username. |
Hi @dar5hak
-GTK4 Granite yohoho
-Added permission to notify because flatpak
-Removed the "set autostart" thingie because flatpak
-Removed the repositioning window thingie because wayland
-Removed the reliance on a py script for meson
-Removed libhandy wtf is that
-Added german
-Added a flathub manifest if you ever want
-split PO files into regular and extra
-changed some deprecated stuff in da metainfo
-Remove the old legacy code for much older settings
-changed icon organization to respect conventions
I saw the translations include the app name. Idk why but i decided to go along with it
Fixes: #85