Break conventions #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dar5hak
approved these changes
Jun 1, 2025
Collaborator
|
Thanks for pointing this out. So going by Leo's comment on the dock issue, we do need to merge this, yes? |
Collaborator
Author
|
I think we can merge. This annoys me. Lets merge this. |
Collaborator
Author
|
Im mad at flathub now. If anyone screams ill tell them eOS does it like this and everyone else is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me again!
So when doing the modern port (which i PRed in one go... should have done several PRs), i moved the SVG to Scalable, and did sized PNGs for Hicolor
Thats apparently a convention. The appcenter says nothing in the matter, but flathub linter has a red warning saying "hey, no SVG in hicolor!" (and i think i saw that they reduce visibility for apps that have more reds in their bullet list?)
So i thought i was doing Badger a favour here
However, on doing some epic hi-res screenshots for the appcenter, i noticed that when scaled to 200%, the icons for Badger (and Jorts which also follows the convention) are blurred - because the dock uses the PNG i believe, while the other apps all go with a SVG as hicolor
so here's a draft PR. Im not sure if its a fault for us or for the dock but in the meantime heres a fix
EDIT: So the freedesktop standard doesnt seem to care about PNG or SVG. Now i am confused if it is a flathub thing or a standard thing, and opened up an issue against the dock, exposing the topic