Fix Gtk critical and warning logs are displayed on startup #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following critical log on startup:
Gtk-CRITICAL **: 21:27:08.382: gtk_box_append: assertion 'gtk_widget_get_parent (child) == NULL' failed
Fix the following warning log on startup:
Gtk-WARNING **: 21:27:08.382: A window is shown after it has been destroyed. This will leave the window in an inconsistent state.
…sent()
Fixes the following build warning:
../src/Application.vala:39:2: warning: ‘gtk_widget_show’ is deprecated: Use 'gtk_widget_set_visible or gtk_window_present' instead [-Wdeprecated-declarations]
39 | window.show ();
| ^ ~~~~~~~~
teamcons
approved these changes
Jan 4, 2026
Collaborator
teamcons
left a comment
teamcons
left a comment
There was a problem hiding this comment.
LGTM! :) Thank you!!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
Can be rebase-merge if desired