Skip to content

Gitlab 124: Implementing fixtures #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Gitlab 124: Implementing fixtures #69

wants to merge 19 commits into from

Conversation

shayfaber
Copy link
Contributor

This branch implements 3 fixtures for tests:

  1. guest with a product in the cart
  2. user (logged in)
  3. user with product in the cart

@shayfaber shayfaber requested a review from dheesen March 18, 2025 09:07
@shayfaber shayfaber requested a review from dheesen March 24, 2025 09:56
Copy link
Collaborator

@dheesen dheesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nagekeken!

@@ -105,21 +23,24 @@ test.describe.serial('Account address book actions', { annotation: {type: 'Accou
* @then I should see a notification my address has been updated.
* @and The new address should be selected as default and shipping address
*/
productTest('Add_the_first_address', {tag: ['@address']}, async ({userPage}, testInfo) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have a look at all these user tests? Looks like this should be called something like userTest right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitlab ticket has been created to rename this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants